Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParamKind to json-abi {,Event}Param #102

Closed
DaniPopes opened this issue Jun 12, 2023 · 3 comments
Closed

Add ParamKind to json-abi {,Event}Param #102

DaniPopes opened this issue Jun 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@DaniPopes
Copy link
Member

currently the type field is unparsed, while ethabi users expect a parsed ParamKind enum. This would also remove the intermediate enum between the {Simple,Complex} structs

@DaniPopes DaniPopes added the enhancement New feature or request label Jun 12, 2023
@cjeva10
Copy link

cjeva10 commented Jul 6, 2023

Hi, I'm interested in working on this - do we mostly want to lift from the ethabi enum ParamType?

If so I can start working on a module to modify it to fit our existing code.

@prestwich
Copy link
Member

This got somewhat re-imagined from when we wrote the issue. Right now, the json-abi is dependency-free, and used in sol! so it cannot depend on dyn-abi as that would cause a dep cycle

@DaniPopes can you update the issue with the current thinking?

@DaniPopes
Copy link
Member Author

This is no longer planned, see #210

@DaniPopes DaniPopes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants