Fix type conversion for deposits causing peak shifts #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated result, causing bias to lower energies. This resulted in a peak shift towards lower energies. To fix this, the number of charges created is instead rounded to the nearest integer
|
Hi @SBlokhuizen thanks a lot for the investigation and the fix! Thanks a lot, |
|
Hi @simonspa |
|
Excellent, thanks! https://gitlab.cern.ch/allpix-squared/allpix-squared/-/merge_requests/982 |
|
@SBlokhuizen sorry for the wait, we wanted to validate a few simulations with this change - it's now in: https://gitlab.cern.ch/allpix-squared/allpix-squared/-/merge_requests/982 This will be part of the next feature release 3.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type conversion for number of charges creation during deposition truncated the result, causing bias to lower energies. This resulted in a peak shift towards lower energies. To fix this, the number of charges created is instead rounded to the nearest integer. Further details are explained here: https://allpix-squared-forum.web.cern.ch/t/charge-creation-type-conversion-introduces-peak-shift-to-lower-energies/405