Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Messenger to allow modules to register to multiple message types #5

Closed
wants to merge 5 commits into from

Conversation

mmoanis
Copy link
Collaborator

@mmoanis mmoanis commented May 22, 2019

This pull request attempt to patch the current messenger implementation to allow modules to register to multiple message types at the same time.

The meaning of the messenger class changed from a message broker to a kind of a mailbox where it just keeps the messages until the receiver asks for them.

The stored messages now in the messenger are not only identified by the module unique name but also by the message type_index; this way a module can receive multiple types.

This, however, will break the check if the module has received the required messages or not and required to refactor this check and move it directly to the module itself.

A new method for the module interface isSatisfied will check if the module received the required messages or not.

Note that the message flags are now useless because we can't tell from the messenger or the delegates if the module is satisfied or not.

@mmoanis mmoanis requested review from simonspa and dhynds May 22, 2019 16:10
@mmoanis mmoanis closed this May 25, 2019
simonspa pushed a commit that referenced this pull request Apr 6, 2021
simonspa added a commit that referenced this pull request Apr 6, 2021
Implement Event-based Multithreading

Closes #8, #4, #5, #7, #184, #203, #166, and #107

See merge request allpix-squared/allpix-squared!231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant