New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only about half of stores returned by costacoffee_gb spider #3805
Comments
We can do @costa-coffee help us out on this? We need an efficient API for all the stores, and ideally the vending machines. |
This spider like many similar (Big Mac anyone?) would benefit from adding a geonames dependency to the project. This has cities by population by territory. These brands in general put their outlets where there are people. ALP sits at about 6,500, I sit at about 8,700 with a less scatter gun geographic query approach. Horses for courses - in many cases the scatter gun is just what you want. In other cases scatter gun with an additional layer of finer grain scatter gun in areas of large population (thanks again geonames). |
@atmos87 ? |
I've added geonames "support" as part of https://githhttps://github.com/alltheplaces/alltheplaces/pull/3831ub.com/alltheplaces/alltheplaces/pull/3831 @rjw62 : if the above makes it into the weekly run this week you will have need McDonald's GB output. I believe the current mcdonals UK output is stunted in a similar manner to Costa here. |
Fixes alltheplaces#3805 A good outing for https://github.com/alltheplaces/alltheplaces/blob/master/locations/geo.py#L87 Looks like @rjw62 and his nifty: https://osm.mathmos.net/chains/ ... was spot the bot on.
https://github.com/alltheplaces/alltheplaces/blob/master/locations/spiders/costacoffee_gb.py
I think the Costa Coffee GB spider is only returning around half of the Costa stores. (My attempt to match the non-express stores from AllThePlaces with OSM data has found only about half of the ~1800 OSM objects with brand:wikidata=Q608845 are matched. See https://osm.mathmos.net/chains/Q608845/ )
For example, the Diss Mere Street store at IP22 4AD is not in the AllThePlaces output: store https://www.costa.co.uk/locations/store-locator/map?latitude=52.3749&longitude=1.1089399999999898&open=1
From the comment at line 17 of costacoffee_gb.py:
# TODO: Can't figure out how to return more than 5 miles
it seems you may already be aware of this, but I couldn't see an issue about it, so I thought it best to create one.
The text was updated successfully, but these errors were encountered: