make visible check for missing elements

alltonp · Aug 13, 2015 · 95028f4 · 95028f4
1 parent 96802e8
commit 95028f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/main/scala/im/mange/driveby/conditions/ElementVisible.scala b/src/main/scala/im/mange/driveby/conditions/ElementVisible.scala
@@ -8,5 +8,5 @@ case class ElementVisible(by: By) extends Condition {
 
   def expectation = expect("ElementVisible", List(by.toString))
   def isSatisfied(browser: UnSafeBrowser) = { browser.isDisplayed(by) == true }
-  def describeFailure(browser: UnSafeBrowser) = { expectation + butWas(() => "hidden") }
+  def describeFailure(browser: UnSafeBrowser) = { expectation + butWas(() => if (browser.exists(by)) "hidden" else "does not exist") }
 }
diff --git a/src/test/scala/im/mange/acceptance/driveby/scalatest/condition/ElementVisibleSpec.scala b/src/test/scala/im/mange/acceptance/driveby/scalatest/condition/ElementVisibleSpec.scala
@@ -21,4 +21,11 @@ class ElementVisibleSpec extends WebSpecification with Matchers {
     thrown.getMessage should equal("""> FAILED: Assert ElementVisible("Id(ElementVisibleWhenHidden)") but was "hidden"  (not met within 2000 millis)""")
   }
 
+  def `fail for id not exist` {
+    val id = "ElementVisibleWhenMissing"
+    val b = given.page(<b>{id}</b>)
+
+    val thrown = the [ConditionNotMetException] thrownBy { b.assert(ElementVisible(Id(id))) }
+    thrown.getMessage should equal(s"""> FAILED: Assert ElementVisible("Id($id)") but was "does not exist"  (not met within 2000 millis)""")
+  }
 }