Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link of type test_case not recognized as proper type in generated report #448

Closed
hennadii-demchenko opened this issue Dec 18, 2019 · 2 comments · Fixed by #732
Closed

Link of type test_case not recognized as proper type in generated report #448

hennadii-demchenko opened this issue Dec 18, 2019 · 2 comments · Fixed by #732
Labels
bug Something isn't working contribute Call for a contribution good first issue Good for newcomers theme:core

Comments

@hennadii-demchenko
Copy link

hennadii-demchenko commented Dec 18, 2019

Bug report:

Steps to reproduce:

  • run simple test:
import allure 

@allure.testcase('TC-1')
def test_foo():
  assert 0
  • generate result: allure generate --clean %alluredir%
  • check links section of generated report

Actual result:

Test case link is not recognized as test management system link, but as plain link

Expected result:

Test case link is recognized as TMS link with appropriate icon (or similar distinctive behaviour)

Additional info and motivation:

Although it is minor issue - this is probably due to unsync with changes in report generator.
If label @allure.link('TC-1', link_type="tms") is provided instead - link is generated correctly.

I guess it might be an easy fix - update allure_commons.types.LinkType.TEST_CASE value to "tms".

Versions:

  • allure-pytest == 2.8.6
  • allure-python-commons == 2.8.6
  • pytest == 5.3.1
  • allure-commandline(2.13.1)
@delatrie
Copy link
Contributor

Yes, there are only two types of link allure treats specially: tms and issue (there is no test_case).
So, the link type should be changed, as suggested, from "test_case" to "tms". If someone is willing to contribute, you are welcome!

@delatrie delatrie added bug Something isn't working good first issue Good for newcomers contribute Call for a contribution theme:core and removed theme:pytest labels Dec 22, 2022
@hennadii-demchenko
Copy link
Author

@delatrie, it's a one-liner, really.
But, ok, no problem, if it is hard for some reason, let me do it for you(it's been only 3 years)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribute Call for a contribution good first issue Good for newcomers theme:core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants