Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report sums rounded durations #430

Merged
merged 1 commit into from Nov 16, 2023
Merged

Report sums rounded durations #430

merged 1 commit into from Nov 16, 2023

Conversation

almarklein
Copy link
Owner

@almarklein almarklein commented Nov 16, 2023

Closes #408.

  • The report dialog now has multiple formats, including second-accuracy 1:21:32, as well as whole hours, and 1, 2, and 3 decimals.
  • The durations of each record rounded according to the format.
  • The totals are obtained by summing the rounded durations.

This way, the shown (rounded) numbers do actually add up to the totals (previously the summing was done on second-precision durations, leading to round-off errors, see #408).


image

@almarklein almarklein merged commit 2f3af74 into main Nov 16, 2023
9 checks passed
@almarklein almarklein deleted the report-rounding branch November 16, 2023 13:56
truecharts-admin added a commit to truecharts/charts that referenced this pull request Dec 16, 2023
…v23.11.4@df703a7 (#16171)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/almarklein/timetagger](https://togithub.com/almarklein/timetagger)
| patch | `v23.11.2` -> `v23.11.4` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>almarklein/timetagger (ghcr.io/almarklein/timetagger)</summary>

###
[`v23.11.4`](https://togithub.com/almarklein/timetagger/releases/tag/v23.11.4)

[Compare
Source](https://togithub.com/almarklein/timetagger/compare/v23.11.3...v23.11.4)

- Fix bug that the total was the taking tag filters into account -
[almarklein/timetagger#433
- Can unselect tags by clicking on them -
[almarklein/timetagger#434

###
[`v23.11.3`](https://togithub.com/almarklein/timetagger/releases/tag/v23.11.3)

[Compare
Source](https://togithub.com/almarklein/timetagger/compare/v23.11.2...v23.11.3)

- Fix overview scrolling on mobile by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[almarklein/timetagger#427
- Tweaks for better experience on mobile by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[almarklein/timetagger#428
- Fix that selecting recent ds does not replace text by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[almarklein/timetagger#429
- Report sums rounded durations by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[almarklein/timetagger#430

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use rounded numbers for totals and subtotals
1 participant