Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Edge hover is not properly removed in dense network #2122

Closed
Tooa opened this issue Sep 28, 2016 · 2 comments
Closed

Edge hover is not properly removed in dense network #2122

Tooa opened this issue Sep 28, 2016 · 2 comments

Comments

@Tooa
Copy link
Member

Tooa commented Sep 28, 2016

Hi,

take a look at this example and dive with the cursor through the middle of the network. You will notice that the "hover" is not cleaned after the cursor leaves the edge.

The issue is maybe related to this pull-request. However, the problem also occurs with the latest develop branch! I think this is the related code for hovering and here is the hovering issued.

EDIT:

I think I got the problem. See my inline comments.

hoverObject(object) {
    [...]
    // removing all edge hover highlights
    for (let edgeId in this.hoverObj.edges) {
        [...]
        // If onMouseMove in the InteractionHandler passes not undefined to the hoverObject 
       // method, but rather another edge, the hover of the old edge is not removed. 
       // This is quite likely to happen for dense networks
        else if (object === undefined) {
          this.blurObject(this.hoverObj.edges[edgeId]);
          delete this.hoverObj.edges[edgeId];
          hoverChanged = true;
        }
      }
    } 

Best Uli

@mojoaxel
Copy link
Member

@Tooa Thanks for that detailed report!!

@mojoaxel mojoaxel added this to the Minor Release v4.17 milestone Oct 26, 2016
@mojoaxel
Copy link
Member

Should be fixed with #2124

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants