Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Use issue and pull request templates #2418

Open
Tooa opened this issue Dec 6, 2016 · 1 comment
Open

Use issue and pull request templates #2418

Tooa opened this issue Dec 6, 2016 · 1 comment
Assignees
@mojoaxel
Milestone
Minor Release v4.22

Comments

@Tooa
Copy link
Member

Tooa commented Dec 6, 2016

A lot of issue tickets miss a minimal example demonstrating the problem or could be solved by taking a look at the documentation. Similar problems occur with external pull requests e.g. they reference the wrong branch or lack updated documentation or examples.

Therefore, I suggest using issue and pull request templates. Following my initial suggestion for the templates. We may add more points and improve the existing ones.

Pull request template

  • Does your pull-request reference the develop branch?
  • Have you updated the documentation?
  • Have you updated the examples?

Issue template

  • Have you already used the search or documentation?
  • Which visjs version are you using?
  • Which browser version are you using?
  • Have you provided the steps to reproduce your issue?
  • Have you provided a minimal example demonstrating your problem (e.g. http://jsbin.com/)?
  • [...]

Best Uli
@Tooa Tooa mentioned this issue Feb 21, 2017
Closed
@mojoaxel mojoaxel added this to the Minor Release v4.19 milestone Feb 21, 2017
@mojoaxel mojoaxel self-assigned this Feb 21, 2017
@mojoaxel
Copy link
Member

Additions:

pull-requests:

issues:

  • General Questions on Stack-Overflow
  • Make clear which component (network, timeline, graph2d, graph3d) you are referring to.

mojoaxel added a commit that referenced this issue Feb 25, 2017
@mojoaxel
added github templates for issues and pull-requests
c4a7111 
fixes #2418
@mojoaxel mojoaxel mentioned this issue Feb 25, 2017
Merged
mojoaxel added a commit that referenced this issue Feb 25, 2017
@mojoaxel
added github templates for issues and pull-requests
c44f384 
fixes #2418
mojoaxel added a commit that referenced this issue Feb 25, 2017
@mojoaxel
added github templates for issues and pull-requests
ff57e7a 
fixes #2418
mojoaxel added a commit that referenced this issue Feb 25, 2017
@mojoaxel
added github templates for issues and pull-requests
0123139 
fixes #2418
mojoaxel added a commit that referenced this issue Feb 26, 2017
@mojoaxel
added github templates for issues and pull-requests
36001be 
fixes #2418
yotamberk pushed a commit that referenced this issue Feb 26, 2017
@mojoaxel @yotamberk
added github templates for issues and pull-requests (#2787)
dd55439 
fixes #2418
marcortw pushed a commit to marcortw/vis that referenced this issue Mar 12, 2017
@mojoaxel @marcortw
added github templates for issues and pull-requests (almende#2787)
051c62e 
fixes almende#2418
yotamberk pushed a commit that referenced this issue May 2, 2017
@marcortw @yotamberk
Implementation of a week scale feature (#3009)
0a64249 
* Add Gitter badge (#2179)

* do not generate source-maps in distribution version

* add 'dist' folder for deployment

* added Badges

* added codeclimate badge

* added @Tooa to the support team

* added badges from isitmaintained.com (#2517)

* do not ignore dist and test folders in master

* generated dist files for v4.18.0

* generated dist files for v4.18.1

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* changed to v4.18.1-SNAPSHOT

* chore(docs): general improvements (#2652)

* removed NOTICE file

* updated license date range to include 2017

* chore(docs): updated support team members

* chore: updated dependencies and devDependencies (#2649)

* Fixes instanceof Object statements for objects from other windows and iFrames. (#2631)

* Replaces instanceof Object checks with typeof to prevent cross tab issues.

* Adds missing space.

* chore: removed google-analytics from all examples (#2670)

* chore(docs): Add note that PRs should be submitted against the `develop` branch (#2623)

Related to: #2618
Related to: #2620

* feat(timeline): Change setCustomTimeTitle title parameter to be a string or a function (#2611)

* change setCustomTimeTitle title parameter, Now could be an string or a function
* Fixed indent and spacing

* feat(timeline): refactor tooltip to only use one dom-element (#2662)

* feat(network): Allow for image nodes to have a selected or broken image (#2601)

* feat(tests): run mocha tests in travis ci (#2687)

* Added showX(YZ)Axis options to Graph3d (#2686)

* Added showX(YZ)Axis to Graph3d

* Added show_Axis options to docs and playground example

* Resolved merge conflict

* Added show_Axis options to docs and playground example

* fix(build): use babel version compatible with webpack@1.14 (#2693)

fixes #2685

* feat(docs): use babel preset2015 for custom builds (#2678)

* add link to a mentioned example (#2709)

* chore(lint): added support for eslint (#2695)

* Trivial typo fix in how_to_help doc. (#2714)

* fix(timeline): #2598 Flickering onUpdateTimeTooltip (#2702)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add animation to onUpdateTooltip

* fix(timeline): #778 Tooltip does not work with background items in timeline (#2703)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Make items z-index default to 1

* Add initial tests for Timeline PointItem (#2716)

* fix(timeline): #2679 TypeError: Cannot read property 'hasOwnProperty' of null (#2735)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Fix bug in item editable

* feat(timeline): #2647 Dynamic rolling mode option (#2705)

* Fix redraw order
* Fix error when option is not defined
* Allow template labels
* Add .travis.yml file
* Add experiment travis code
* Fix react example
* Add toggleRollingMode option
* Update docs with toggleRollingMode option

* fixes timestep next issue (#2732)

* feat(timeline): added new locales for french and espanol (#2723)

* Fix eslint problem on Travis. (#2744)

* fix: Range.js "event" is undeclared (#2749)

* fix(timeline): #2720 Problems with option editable (#2743)

Clean up and centralise edit status for Timeline Items.

* feat(network): Improve the performance of the network layout engine (#2729)

* Improve the performance of the network layout engine

Short-cut the execution of a number of methods in LayoutEngine to make them
handle highly-connected graphs better.

* Demonstrations of layouts of large networks

* Added support to supply an end to bar charts to have them scale (#2760)

* Added support to supply an X2 to bar charts to have them scale

* Fixed graph2d stacking issue.  It no longer takes into account hidden items

* Changed x2 to end per recommendation and added this to the docs

* Initial tests for timeline ItemSet. (#2750)

Somewhat more complicated setup, associated with the need for a real window.

* [Timeline] Modify redraw logic to treat scroll as needing restack. (#2774)

This addresses #1982 and #1417.

It possibly reduces performance, but correctness seems better.

* fix(timeline): #2672 Item events original event (#2704)

* Fix redraw order

* Fix error when option is not defined

* Allow template labels

* Add .travis.yml file

* Add experiment travis code

* Fix react example

* Fix events returned from mouse events

* Fix example

* Rename censor to stringifyObject in example

* [timeline] Update examples to use ISOString format. (#2791)

Resolves #2790

* [timeline] Update serialization example to use ISOString dates. (#2789)

Resolves #2696

* added github templates for issues and pull-requests (#2787)

fixes #2418

* feat(timeline): Add item data as argument to the template function (#2799)

* Fix regression introduced in #2743. (#2796)

* Fix for issue #2536 (#2803)

* Fix for issue #2536

* Adjusted documentation for fix.

* Adjustments due to review

* Grrrrr whitespace

* Fixed Travis issue

* Cheap fix for bug #2795

* Update to PR #2826 to use newline format

* Update to gitignore to reflect changes on remote

* clean dist folder

* Local gitignore update

* Just a first example file for the week scale feature

* Allowing sourcemap creation

* Initial (non-functional) commit to ensure we insert code at the right places (check TODOs)

* Functional, not bug-free version which works with locale aware week numbers.

* Locale-aware implementation and simplified major labels to a full year

* Trying to make the major labels show the correct start date

* Working implementation of week numbers using localization.

* removing development leftovers

* Updated package.json

* Reintagrate package.json from accidental deletion

* Updates for package.json

* Fixing package.json

* Integrate the week numbers feature in the documentation.

* Reverting local changes to .gitignore

* Reverting local changes

* Extending examples to cover the case when 1st day of week and 1st day of month align; Fixing display bug so that week numbers are not repeated in minorLabels

* Putting the examples into a loop
@mojoaxel mojoaxel modified the milestones: Minor Release v4.20, Minor Release v4.21 May 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mojoaxel mojoaxel

Labels
None yet
Projects
None yet
Milestone
Minor Release v4.22
Development

No branches or pull requests
2 participants
@mojoaxel @Tooa