Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Add point draw methods for styles 'dot' and 'dot-line' #2212

Merged
merged 2 commits into from Oct 23, 2016

Conversation

wimrijnders
Copy link
Contributor

  • Added point drawing routines for dot and dot-line
  • Moved selection of point drawing method to separate method
  • DRY'd color selection for graph styles bar and dot

Style dot-line was actually absurdly easy to implement; it's just dot
with an extra line.

Copy link
Contributor

@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we said this before, but please make sure all the examples are working. These are breaking changes and I usually sample some of the examples but I don't get to check all of them in-depth. I trust you know what you are doing =)
(We need to start considering a testing tool. As the features stack up, it's getting harder to test manually...)

@mojoaxel mojoaxel merged commit 1c4e1a4 into almende:develop Oct 23, 2016
@wimrijnders
Copy link
Contributor Author

I test every time I make a pull request. Usually, I try out all the options in the tooltips demo to see if they all still work. For the current work, I think this is proof enough that it works.

As the features stack up, it's getting harder to test manually..

The thing to note is that with all these changes I'm making, the external working of Graph3d doesn't change at all! It's just one big refactoring 😉 .

@wimrijnders wimrijnders deleted the PR22 branch October 23, 2016 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants