This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
make sure a given element isn’t undefined before accessing properties #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I prefer #2401 😉 |
mojoaxel
approved these changes
Dec 3, 2016
|
take #2401, the it's all the same! :-) |
|
@eymiha It's your bug I'm ok with you fixing it! |
|
Thanks! I've been using the constraints with multiple fonts and it's all really working nicely for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2402
the util.topMost functions searches a pile of candidates for the first that defines an accessor. But no check was being done for the presence of a candidate before checking. An added conditional now prevents this from happening.