Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

added order definition #4091

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

added order definition #4091

wants to merge 1 commit into from

Conversation

avrahamcool
Copy link

fixed none to no in the required column

avrahamcool added a commit to visjs-community/DefinitelyTyped that referenced this pull request Aug 23, 2018
currently missing from official docs.
awaiting merge almende/vis#4091
Copy link

@adripanico adripanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is actually being taking into account for the ordering of the groups and wasn't present in the documentation. See DefinitelyTyped/DefinitelyTyped#28327 (comment)

@yotamberk
Copy link
Contributor

I've now branched out to a new fork of my own including only Timeline.
I've applied your change here: https://github.com/yotamberk/timeline-plus
and can be used via npm here: https://www.npmjs.com/package/timeline-plus
Awesome fix! Thanks for your contribution! Future PRs will be reviewed and added in the new fork

mojoaxel pushed a commit to visjs/vis-types that referenced this pull request Jul 27, 2019
currently missing from official docs.
awaiting merge almende/vis#4091
mojoaxel pushed a commit to visjs/vis-types that referenced this pull request Jul 27, 2019
currently missing from official docs.
awaiting merge almende/vis#4091
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants