Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix Proactive Remediation #67

Merged
merged 10 commits into from
Nov 25, 2022
Merged

Bug fix Proactive Remediation #67

merged 10 commits into from
Nov 25, 2022

Conversation

almenscorner
Copy link
Owner

Bug fix where Proactive Remediations were not able to be backed up when containing a "/" in the display name.

closes #66

@almenscorner almenscorner added bug Something isn't working fixed Bug has been fixed labels Nov 25, 2022
@almenscorner almenscorner self-assigned this Nov 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Base: 97.18% // Head: 97.19% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (50cfdd5) compared to base (d40fb83).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   97.18%   97.19%   +0.01%     
==========================================
  Files          50       50              
  Lines        2341     2354      +13     
==========================================
+ Hits         2275     2288      +13     
  Misses         66       66              
Flag Coverage Δ
unittests 97.19% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/IntuneCD/backup_proactiveRemediation.py 100.00% <ø> (ø)
src/IntuneCD/graph_request.py 98.55% <100.00%> (+0.24%) ⬆️
src/IntuneCD/update_conditionalAccess.py 100.00% <100.00%> (ø)
src/IntuneCD/update_proactiveRemediation.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@almenscorner almenscorner merged commit 85588db into main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Bug has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Backup fails when Proactive Remediation has "/" character in Title
2 participants