Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve searching and image matching capabilities #2

Merged
merged 2 commits into from Apr 4, 2018
Merged

Improve searching and image matching capabilities #2

merged 2 commits into from Apr 4, 2018

Conversation

ntninja
Copy link
Contributor

@ntninja ntninja commented Oct 4, 2014

Improved search for images

  • More than one directory may be searched
    • List of directories is now expected in the form of positional command line arguments
    • The -p option previously used to select the target directory is still supported
    • If no directories are provided (no positional command line arguments and no usage of -p) then the current directory is used
  • Directories can now be searched recursively (using -R)
    • Symlinks can be followed when searching recursively (using -f)
  • Image formats are now detected using the python mimetypes modules
    • It extension based and therefor not always reliable but its a major improvement nonetheless

Minor clean up

  • Disabled --set-background option (since it doesn't work outside of GNOME 2.x)

Updated README

  • Made text in README mention the fact that there are several desktop environment supporting this format nowadays
  • Updated the command line help of gnome-background-generator
  • Added two examples for usage of gnome-background-generator

@ntninja
* Allow more than one directory to be searched (changed CLI interface)
3fc6157 
 * Disabled --set-background option (since it doesn't work outside of GNOME 2.x)
 * Allow recursive walking of the given directories (with or without symlinks)
 * Improved image file detection (using python `mimetypes` module - it's a start...)
@ntninja
Updated README with new commandline options
393f276
@almet
Copy link
Owner

almet commented Apr 4, 2018

I actually never saw this pull request, and completely forgot the mere existence of this repository. I'll be merging this, I hope it still works ;)

@almet almet merged commit 3243519 into almet:master Apr 4, 2018
@ntninja
Copy link
Contributor Author

ntninja commented Apr 4, 2018

completely forgot the mere existence of this repository

Me too! Nice stuff I did there apprently. 😉

I hope it still works

Probably, but I wouldn't know either. 🙂

Well, thanks for merging anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ntninja @almet