Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minification error #30

Closed
azu opened this issue May 25, 2016 · 0 comments · Fixed by #31
Closed

minification error #30

azu opened this issue May 25, 2016 · 0 comments · Fixed by #31

Comments

@azu
Copy link
Member

azu commented May 25, 2016

When use Almin with minification like UglifyJs, always throw error.

assert.js:113Uncaught AssertionError: "t" is duplicated in the `new StoreGroup(stores)`.
You should check each Store class name.

class t extends Store { ... }
      ^
      store.name

It is caused by minification, it make store name to t.

Workaround

use unassert.

@azu azu changed the title ``` minification error May 25, 2016
azu added a commit that referenced this issue May 25, 2016
It is not needed. We detect same value using WeakMap.

fix #30 minification issue
@azu azu closed this as completed in #31 May 25, 2016
azu added a commit that referenced this issue May 25, 2016
It is not needed. We detect same value using WeakMap.

fix #30 minification issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant