Remove ***Payload.Type static property #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetsuharuohzeki
commented
Feb 20, 2017
| @@ -5,11 +5,6 @@ import Payload from "./Payload"; | |||
| export const TYPE = "ALMIN__WILL_EXECUTED_EACH_USECASE__"; | |||
There was a problem hiding this comment.
@azu we should write the comment like following?
XXX: This is exported for unit testing.
DO NOT USE THIS in your application.
- Breaking Change - Fix almin#86 - To detect the type of `***Payload`, you should use `is***Payload()`.
tetsuharuohzeki
force-pushed
the
rm-static-type
branch
from
560c710
to
994fb0a
Compare
|
@azu I updated the patch. |
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
***Payload, you should useis***Payload().