Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep MADCTL value to use with orientation changes #14

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Conversation

almindor
Copy link
Owner

@almindor almindor commented Mar 31, 2022

Keeps MADCTL value from model init and uses it with orientation writes to keep the color and other definitions.

Should fix #7 and #8 and enable a fix for #10

I've also switched to pure static dispatch for all cases with WriteOnlyDataCommand

@almindor almindor mentioned this pull request Mar 31, 2022
Copy link
Contributor

@brianmay brianmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change and think this is the correct strategy for fixing the problem that updating the orientation will overwrite the MADCTL values.

src/lib.rs Outdated Show resolved Hide resolved
@brianmay
Copy link
Contributor

I see nothing here that will fix #7 or #8. And fix for #10 still requires some way of setting the madctl value which looks like it is still hard coded per each driver. But good step in correct direction.

@almindor almindor merged commit 0af9ad0 into master Mar 31, 2022
@almindor
Copy link
Owner Author

I see nothing here that will fix #7 or #8. And fix for #10 still requires some way of setting the madctl value which looks like it is still hard coded per each driver. But good step in correct direction.

Correct. I'll check #9 for the orientation fix once it's rebased.

I'll make a new change for exposing the color inversion once we confirm it works with this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screen orientations are hardcoded
2 participants