Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCS instruction abstraction #44

Merged
merged 36 commits into from
Feb 18, 2023
Merged

DCS instruction abstraction #44

merged 36 commits into from
Feb 18, 2023

Conversation

almindor
Copy link
Owner

@almindor almindor commented Dec 12, 2022 •
edited
Loading

Adds DCS abstraction and a new Dcs wrapper on top of display-interface to:

  1. Ensure correct and safe use of DCS commands (where applicable)
  2. Make init code for models more readable
  3. Separate the DCS aspects out to another crate (in a separate PR)

@almindor almindor self-assigned this Dec 12, 2022
@almindor almindor mentioned this pull request Dec 12, 2022
Closed
rfuest
rfuest requested changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@rfuest rfuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better than before. Here are some suggestions for further improvements.

src/builder.rs Outdated Show resolved Hide resolved
src/dcs.rs Outdated Show resolved Hide resolved
src/dcs.rs Outdated Show resolved Hide resolved
src/dcs/caset.rs Outdated Show resolved Hide resolved
src/dcs/caset.rs Outdated Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
src/instruction.rs Outdated Show resolved Hide resolved
src/builder.rs Show resolved Hide resolved
src/dcs.rs Outdated Show resolved Hide resolved
src/models/ili9486.rs Show resolved Hide resolved
@almindor almindor mentioned this pull request Jan 12, 2023
Merged
@almindor almindor merged commit ac32e8c into master Feb 18, 2023
@Dominaezzz Dominaezzz mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfuest rfuest rfuest requested changes

Assignees

@almindor almindor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@almindor @rfuest