Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newer Node.js versions for prebuilt binaries #15

Merged
merged 4 commits into from
May 28, 2021

Conversation

ShinySaana
Copy link
Contributor

@ShinySaana ShinySaana commented May 25, 2021

Audify is behind 2 major version releases for Node, both in "classic" Node and electron-node, which can impact projects which rely on those. This simple patch should add those newer versions to the batch of binaries that are built for each releases.

Copy link
Owner

@almoghamdani almoghamdani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason why the Node.js that is installed on the build machine should be the latest and not LTS (which should be more stable)
This should not affect building for newer/older Node.js versions (since cmake-js downloads the correct lib/headers for each version and links against it - therefore not related to the installed node.js)

@almoghamdani
Copy link
Owner

Also, please update the README with the new supported versions for prebuilts

@ShinySaana
Copy link
Contributor Author

(since cmake-js downloads the correct lib/headers for each version and links against it - therefore not related to the installed node.js)

I didn't know that, modifying this right away

@ShinySaana
Copy link
Contributor Author

For some unknown reason, Travis failed for the first commit but passed fine for the following, so I believe it's ready now!

@almoghamdani almoghamdani merged commit ba73d3d into almoghamdani:master May 28, 2021
@ShinySaana
Copy link
Contributor Author

Okay so the build crashed on master, and by looking the travis builds, my first guess would because of artifact caching between builds, and that we indeed need the latest version and not the LTS one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants