Pass metadata in completion replies for jupyterlab-lsp #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is duplicating the completion code from Ammonite here temporary, i.e. the same changes are to be merged backed into Ammonite, or permanent? If it's the latter maybe after this we can add the scalapy completion here as well. |
|
@kiendang I wasn't too sure, but the ability to add the ScalaPy completions would be a good argument to add it here |
alexarchambault
force-pushed
the
completion-metadata-for-jupyterlab-lsp
branch
3 times, most recently
from
2110941
to
3ede3c1
Compare
alexarchambault
force-pushed
the
completion-metadata-for-jupyterlab-lsp
branch
from
3ede3c1
to
ee200d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.