Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dame off by one error on stopping iterations #34

Merged
merged 22 commits into from
May 24, 2021

Conversation

nehargupta
Copy link
Collaborator

No description provided.

nehargupta and others added 22 commits December 26, 2020 19:25
copied Tommy's travis file in attempt to get the windows/mac setup going

Co-Authored-By: Thomas Howell <65472983+thowell332@users.noreply.github.com>
updated numpy higher in attempt to get it to work on python 3.7 in linux
changed pip to pip3 in attempt to get mac to work
there's a python 3.9 apparently ugh
add installation of nose to hopefully get it to work on mac
also added python 3.9 haha
update nose installation to --user to try to get it to work for mac still
adjust windows 3.6 to 3.6.5

change language to generic to try to get macos to work.
now running install nose without pip3
removed macos and windows 2.6 attempts, done trying to fix that lol.

now trying to get it configured to run all versions of scikit with all versions of python
put pip3 back to try to get windows to work again
try to define environment variables differently so it works on windows too again
try mixing numpy versions and scikit versions and see what happens
not sure why numpy not going
another attempt to get numpy to vary
just realized that scikit uses numpy, scipy and pandas, so maybe we really only need scikit as a dependency??
hmm  maybe that doesnt work??
no dashes I guess?
Off by one in stopping criteria for DAME, so factored it out of dame_flame_helpers.
Also, initial steps to flagging the overflow issue, but this needs to be more seriously dealt with
@nehargupta nehargupta merged commit b87c029 into almost-matching-exactly:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant