Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions for installing pickle with cgr #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonphipps
Copy link

Description

cgr doesn't allow 'install' or 'global'.

I was also bit by the 'cgr alias' conflict in the oh-my-zsh project. But that's another issue.

Motivation and context

Why is this change required? What problem does it solve?

Couldn't install pickle with the supplied instructions. The instructions in the slides are wrong too.

How has this been tested?

Please describe in detail how you tested your changes.

Could install pickle! Yay.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

I was also bit by the ['cgr alias' conflict](https://github.com/consolidation/cgr#troubleshooting) in the oh-my-zsh project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant