Merge pull request #146 from aloetesting/fix-warnings

Fix Pylint warnings

.travis.yml

@@ -1,14 +1,20 @@
 language: python
 
-python:
-    - "2.7"
-    - "3.4"
-    - "3.5"
-    - "3.6"
+matrix:
+  include:
+    - python: "3.6"
+      env: PYLINT_FLAGS=
+    - python: "3.5"
+      env: PYLINT_FLAGS=
+    - python: "3.4"
+      env: PYLINT_FLAGS=
+    - python: "2.7"
+      env: PYLINT_FLAGS="--disable bad-continuation"
 
 install:
     - pip install -r requirements.txt
     - pip install -r test_requirements.txt
+    - pip install --upgrade pycodestyle pylint
     - pip install coveralls
 
 cache:
@@ -17,7 +23,7 @@ cache:
 
 script:
     - pycodestyle .
-    - pylint aloe aloe_sphinx tests
+    - pylint $PYLINT_FLAGS aloe aloe_sphinx tests
     - coverage erase
     - coverage run -m nose
     - coverage report

appveyor.yml

@@ -4,9 +4,13 @@ environment:
 
   matrix:
     - PYTHON: "C:\\Python36-x64"
+      PYLINT_FLAGS: ""
     - PYTHON: "C:\\Python35-x64"
+      PYLINT_FLAGS: ""
     - PYTHON: "C:\\Python34-x64"
+      PYLINT_FLAGS: ""
     - PYTHON: "C:\\Python27"
+      PYLINT_FLAGS: "--disable bad-continuation"
 
 install:
   - git config core.symlinks true
@@ -16,12 +20,13 @@ install:
   - python -m easy_install -U setuptools
   - pip install -r requirements.txt
   - pip install -r test_requirements.txt
+  - pip install --upgrade pycodestyle pylint
 
 build: off
 
 test_script:
   - pycodestyle .
-  - pylint aloe aloe_sphinx tests
+  - pylint %PYLINT_FLAGS% aloe aloe_sphinx tests
   - coverage erase
   - coverage run -m nose
   - coverage report

pylintrc

@@ -20,6 +20,7 @@ disable=
     no-self-use,
     too-few-public-methods,
     too-many-lines,
+    useless-object-inheritance,
     unused-argument,
     wrong-import-order,
     RP0101,

test_requirements.txt

@@ -2,6 +2,6 @@ coverage
 factory_boy
 mock
 pycodestyle
-pylint>=1.8.0
+pylint>=1.9.3
 setuptools_scm
 Sphinx

tests/integration/test_simple.py

@@ -103,9 +103,9 @@ def read(file_desc):
                     return data
 
                 with set_environ(
-                    COLORTERM='',
-                    TERM='xterm-256color',
-                    TERM_PROGRAM='',
+                        COLORTERM='',
+                        TERM='xterm-256color',
+                        TERM_PROGRAM='',
                 ):
 
                     status = pty.spawn(args, read)  # pylint:disable=assignment-from-no-return