Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser/linklist] every host of a linklist shows up 2 times.. #415

Closed
jdlx opened this issue Jan 29, 2012 · 16 comments · Fixed by evo42/Aloha-Editor#5
Closed

[browser/linklist] every host of a linklist shows up 2 times.. #415

jdlx opened this issue Jan 29, 2012 · 16 comments · Fixed by evo42/Aloha-Editor#5
Assignees

Comments

@jdlx
Copy link

jdlx commented Jan 29, 2012

Each host (as a tree root) from a given linklist shows up 2 times in the browser's tree. Dunno if related to this or a issue of it' own (or expected behavior?): once you click any folder in the tree, all available links from that root are shown on the right hand side..

note: i tried to debug the "doubled root" issue.. it seems to me like the issue doesn't come from linklist.js, but rather browser.js, alas i couldn't nail it down in there.. my JS knowhow is too limited ;)

@petrosalema
Copy link
Member

Was this happening in the boilerplate demo?

@jdlx
Copy link
Author

jdlx commented Jan 30, 2012

Happens in any demo i try.. even on the website: http://awesomescreenshot.com/071t4ezbf
tested in FF/Safari/Chrome on OSX..

@evo42
Copy link
Member

evo42 commented Jan 31, 2012

@nka11
Copy link
Member

nka11 commented Feb 28, 2012

Confirm also this kind bug while implementing the repository for my back end, with a custom explorer (it's not only a bug in linklist, nor in link repository but in explorer component itself).
Entries appears duplicated in the tree panel but not in the flat view panel.

Additionally, I can't figure out why types document don't appear in the view panel with, or without the renditions properties.

I've also noticed that entries from a repository appears in all repositories, eg, my entry a in the karacos repository appears also in the linklist tree and vice-versa.

I'll try to go deeper this week, hope i'll fix it quickly..

nka11 added a commit to karacos/Aloha-Editor that referenced this issue Feb 29, 2012
@nka11
Copy link
Member

nka11 commented Feb 29, 2012

it was quicker than expected...

What I did :
Rewrote one method in browser to ensure unique jstree node object for a given repository object. Using md5 hash against repository object id as input for object uid attribute used by jstree.

@nka11
Copy link
Member

nka11 commented Mar 27, 2012

@jdlx @petro065 this issue should be fixed in latest release branch.

Please review and close if concluant.

@jdlx
Copy link
Author

jdlx commented Mar 30, 2012

just DL'd 0.20.7 .. issue remains for me.
checked in FF, Safari & Chrome on OSX 10.6 ..
http://awesomescreenshot.com/0a12fvq06

@nka11
Copy link
Member

nka11 commented Mar 30, 2012

@jdlx fix will come in 0.21 (or you can checkout latest release branch)

@jdlx
Copy link
Author

jdlx commented Mar 30, 2012

@nka11 sry, misunderstood you.. yes, the "multiple root" issue is gone in the latest release branch.. however the issue with all links being shown regardless of where you click in the linklist tree remains: http://awesomescreenshot.com/03e2fxpd9
(i doubt this is expected behaviour, as there wouldn't be a need for a tree in the first place.. ;)

@nka11
Copy link
Member

nka11 commented Mar 30, 2012

Hi @jdlx,
Thanks for your feedback.
For the second point, i've opened a new issue as it might be a completely different problem.
could you close that one if you're able to ?

@jdlx
Copy link
Author

jdlx commented Mar 30, 2012

ok, done..

@jdlx jdlx closed this as completed Mar 30, 2012
@mrchapov
Copy link

WIth the patch of nka11, some other functions does not work. I cant understand, why you use md5.... Im using Aloha from today, and find the solution of the problem. Just rewrite "harvestRepoObject" function in browser.js with this:
harvestRepoObject: function (obj) {
var u = obj['id'];
if (obj['type'] != 'host' || (obj['type'] == 'host' && typeof(this._objs[obj['id']]) == 'undefined')) {
var repo_obj = this._objs[obj['id']] = jQuery.extend(obj, {
uid : u,
loaded : false
});
}
return this.processRepoObject(repo_obj);
},

But there is another problem. I have 2 different trees with links, but wherever I click in the tree, the right content is not altered.

@jdlx
Copy link
Author

jdlx commented Apr 10, 2012

the second prob you're mentioning is a dupe of #491

@mrchapov
Copy link

Yes... And now I`m gonna to fix this problem.

@jdlx
Copy link
Author

jdlx commented Apr 10, 2012

ride on.. ;) maybe you feel like tweaking this one while you're at it.. ;) #492

@jdlx jdlx reopened this Apr 28, 2012
@jdlx
Copy link
Author

jdlx commented Apr 28, 2012

Hi, ich checked master, dev & release today (29.4): the double host bug is back in..

@ghost ghost assigned evo42 Oct 15, 2012
@evo42 evo42 closed this as completed Oct 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants