Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Attributes Content Handler #1076

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ggalileo
Copy link
Contributor

@ggalileo ggalileo commented Feb 6, 2014

This pull request is for a new common content handler that we have developed at Constant Contact.

The Style Attribute Content Handler will remove all unsupported style attribute items from all elements in the supplied content. The set of supported style attribute items is configured in the same manner as other content handler plugins via config in

Aloha.settings.contentHandler.handler.styleattribute.

This code has been tested across browsers by our QE and is used in our product.

  1. obey coding guidelines
  2. write JSLint compliant code
  3. write JSDoc for every method you touched during your implementation
  4. write a human-readable :) Changelog entry that describes your change
  5. add a qunit test (if it makes sense) and/or document the steps to manually test it (in a separate guides page)
  6. test your changes in Internet Explorer 7, 8, 9 and the latest Firefox and latest Chrome
  7. document your changes in a guides page
  8. include this list in a your pull request

@Jotschi
Copy link
Contributor

Jotschi commented Feb 7, 2014

Request looks good.

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

@Jotschi
Copy link
Contributor

Jotschi commented Feb 19, 2014

Admin please build this request

@GenticsDev
Copy link
Contributor

Test PASSed.
Refer to this link for build results: http://jenkins.office:8080/job/alohaeditor-upstream-pullrequests/17/

@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GenticsDev
Copy link
Contributor

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants