Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajouter la balise theme-color manquante #17

Closed
aloisdg opened this issue Feb 28, 2023 · 2 comments
Closed

Ajouter la balise theme-color manquante #17

aloisdg opened this issue Feb 28, 2023 · 2 comments
Assignees
@Lodanslhuile
Labels
dev good first issue Good for newcomers

Comments

@aloisdg
Copy link
Owner

aloisdg commented Feb 28, 2023 •
edited

Hello,

Chrome nous remonte un léger warning

image

transcript:

Does not set a theme color for the address bar.Failures: No `<meta name="theme-color">` tag found.

Premièrement, ajoutez une balise meta theme-color à index.html:

<head>
  …
<meta name="theme-color" media="(prefers-color-scheme: light)" content="#fff" />
<meta name="theme-color" media="(prefers-color-scheme: dark)" content="#202b38" />
  …
</head>

deuxièment, ajouter une propriété theme_color au manifest.webmanifest :

{
  …
  "theme_color": "#202b38"
  …
}

Hélas le web.manifest ne supporte pas la préférence de thème. Il va falloir choisir un thème par défaut pour l'app. Clair ou obscure ? (mon coeur balance pour obscure mais voyons avec @Polibous).

La bonne nouvelle c'est que c'est cours de développement. J'invite à aller lire cet échange pour voir comment une fonctionnalité est créée: Add support for defining a theme color for both light & dark modes (prefers color scheme)

source:
@aloisdg aloisdg added good first issue Good for newcomers dev labels Feb 28, 2023
@Lodanslhuile
Copy link
Contributor

Bonjour,

Est-ce que je peux prendre cette issue?

Bonne journée

@aloisdg
Copy link
Owner Author

aloisdg commented Mar 3, 2023

Yes !

Lodanslhuile added a commit to Lodanslhuile/pointmedian.lorena that referenced this issue Mar 3, 2023
@Lodanslhuile
Ajout balise color manquante issue aloisdg#17
a185c09
@aloisdg aloisdg closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lodanslhuile Lodanslhuile

Labels
dev good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aloisdg @Lodanslhuile