gnupg-pkcs11-scd: add PKAUTH command support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
force-pushed
the
add-auth-support
branch
from
cf6c1d7
to
eda396e
Compare
alonbl
reviewed
Mar 19, 2021
invidian
force-pushed
the
add-auth-support
branch
from
eda396e
to
f8889bf
Compare
This commit adds PKAUTH command support to gnupg-pkcs11-scd, so gpg-agent with "enable-ssh-support" setting defined can act as a SSH Agent when PKCS11 is used as a GPG backend. Auth operation is almost the same as sign operation, except it looks like SSH always sends data with hash algorithm signature appended at the beginning, but the data is of different size than the signature detection code expects, so it always fallback to default behavior, which is to append SHA1 signature. As having 2 different signature prefixes is incorrect, we need to use the different default value from the sign action, which is to not append anything in case of auth operation. Closes alonbl#27 Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
invidian
force-pushed
the
add-auth-support
branch
from
f8889bf
to
529d4d7
Compare
|
Fixed one more inconsistent indentation. |
alonbl
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds PKAUTH command support to gnupg-pkcs11-scd, so
gpg-agent with "enable-ssh-support" setting defined can act as a SSH
Agent when PKCS11 is used as a GPG backend.
Auth operation is almost the same as sign operation, except it looks
like SSH always sends data with hash algorithm signature appended at the
beginning, but the data is of different size than the signature
detection code expects, so it always fallback to default behavior, which
is to append SHA1 signature.
As having 2 different signature prefixes is incorrect, we need to
use the different default value from the sign action, which is to not
append anything in case of auth operation.
Closes #27
Signed-off-by: Mateusz Gozdek mgozdekof@gmail.com