Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 2.13 compilation target #142

Merged
merged 42 commits into from Aug 23, 2019
Merged

Add Scala 2.13 compilation target #142

merged 42 commits into from Aug 23, 2019

Conversation

alonsodomin
Copy link
Owner

No description provided.

@alonsodomin
Copy link
Owner Author

Re-opening after wrong automatic merge happening in #141

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #142 into master will increase coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #142      +/-   ##
=========================================
+ Coverage   90.66%   91.4%   +0.74%     
=========================================
  Files          60      69       +9     
  Lines        1050    1199     +149     
  Branches       44      45       +1     
=========================================
+ Hits          952    1096     +144     
- Misses         98     103       +5
Impacted Files Coverage Δ
...core/shared/src/main/scala/cron4s/expr/nodes.scala 78.65% <0%> (-1.35%) ⬇️
...ain/scala/cron4s/testkit/CronDateTimeTestKit.scala 100% <0%> (ø) ⬆️
...c/main/scala/cron4s/validation/NodeValidator.scala 100% <0%> (ø) ⬆️
...main/scala/cron4s/testkit/gen/CronGenerators.scala 100% <0%> (ø) ⬆️
...e/shared/src/main/scala/cron4s/expr/CronExpr.scala 100% <0%> (ø) ⬆️
...dules/core/shared/src/main/scala/cron4s/Cron.scala 100% <0%> (ø) ⬆️
.../main/scala/cron4s/datetime/PredicateReducer.scala 100% <0%> (ø) ⬆️
.../cron4s/testkit/gen/ArbitraryCronFieldValues.scala 100% <0%> (ø) ⬆️
...main/scala/cron4s/testkit/discipline/package.scala 0% <0%> (ø) ⬆️
...shared/src/main/scala/cron4s/parsing/package.scala
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00977f2...4d902c0. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #142 into master will decrease coverage by 10.26%.
The diff coverage is 75.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #142       +/-   ##
===========================================
- Coverage   90.89%   80.63%   -10.27%     
===========================================
  Files          70       64        -6     
  Lines        1208     1172       -36     
  Branches       39       48        +9     
===========================================
- Hits         1098      945      -153     
- Misses        110      227      +117
Impacted Files Coverage Δ
...ain/scala/cron4s/testkit/laws/IsDateTimeLaws.scala 100% <ø> (ø)
.../src/main/scala/cron4s/bench/ParserBenchmark.scala 0% <ø> (ø)
.../cron4s/testkit/discipline/DateTimeCronTests.scala 100% <ø> (ø)
.../main/scala/cron4s/testkit/IsDateTimeTestKit.scala 100% <ø> (ø)
...core/shared/src/main/scala/cron4s/expr/nodes.scala 80.3% <ø> (+1.65%) ⬆️
...la/cron4s/testkit/discipline/EnumeratedTests.scala 100% <ø> (ø)
...main/scala/cron4s/testkit/discipline/package.scala 0% <ø> (ø)
...main/scala/cron4s/testkit/gen/NodeGenerators.scala 96.55% <ø> (ø)
...ain/scala/cron4s/testkit/DateTimeCronTestKit.scala 100% <ø> (ø)
...core/shared/src/main/scala/cron4s/expr/parts.scala 0% <ø> (-33.34%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adda7cf...6397c61. Read the comment docs.

@pjfanning
Copy link
Contributor

pjfanning commented Jun 27, 2019

@alonsodomin would it be possible to use cats-core 2.0.0-M4 for scala 2.13.0 compile?

@alonsodomin
Copy link
Owner Author

alonsodomin commented Jun 28, 2019

@pjfanning yeah, of course, it will need to be versioned as a milestone too though.

However, this is blocked on a release of propensive/contextual; not sure if it was already released or not...

@alonsodomin alonsodomin mentioned this pull request Jul 17, 2019
@alonsodomin
Copy link
Owner Author

Once the build passes, this closes #187

@alonsodomin alonsodomin changed the title WIP: Add Scala 2.13 target Add Scala 2.13 compilation target Jul 19, 2019
@alonsodomin
Copy link
Owner Author

Finally got a successful build in Scala 2.12, the Scala 2.13 build is failing due to a macro expansion error in the cron macro powered by contextual

@alonsodomin alonsodomin merged commit abe7905 into master Aug 23, 2019
@alonsodomin alonsodomin deleted the scala_2_13 branch August 23, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants