Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SettingsGroup usage #270

Merged
merged 2 commits into from
May 24, 2024
Merged

Add SettingsGroup usage #270

merged 2 commits into from
May 24, 2024

Conversation

TinyHai
Copy link
Contributor

@TinyHai TinyHai commented May 24, 2024

No description provided.

@alorma
Copy link
Owner

alorma commented May 24, 2024

I was wondering, @TinyHai .

Should tiles have a "disabled color" for texts?

Til now I don't provide a way to change texts colors (only "actions") and I wonder if it could be util or necessary.

Any thoughts?

@alorma alorma merged commit 4bdfc32 into alorma:main May 24, 2024
8 checks passed
@TinyHai
Copy link
Contributor Author

TinyHai commented May 24, 2024

I was wondering, @TinyHai .

Should tiles have a "disabled color" for texts?

Til now I don't provide a way to change texts colors (only "actions") and I wonder if it could be util or necessary.

Any thoughts?

Accoding to M3 Lists spec. disabled componets have a color opacity.

I think we should add the opacity to disabled component, but providing a way to change is not necessary

@alorma
Copy link
Owner

alorma commented May 24, 2024

I think we should add the opacity to disabled component, but providing a way to change is not necessary

Yes of course! Maybe similar to how material3 handle colors, with a Settings....Defaults.colors() method?

@TinyHai
Copy link
Contributor Author

TinyHai commented May 25, 2024

Yes of course! Maybe similar to how material3 handle colors, with a Settings....Defaults.colors() method?

no need, the colors google provided is fine. we just need to handle the opacity. see #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants