Remove shared state from IR #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm starting to refactor the IR by replacing all the double pointers with declaration IDs, removing the shared state. There are a few spots that use unsafe and they immediately gave me a big segfault! Still a bit of work to do but at least it compiles! Signed-off-by: Jadon Fowler <j@jadon.io>
Instead of having blocks and instructions reference each other in the IR, everything has been changed to use stateless "IDs". This removes all pointers from structures and clears up a lot of the lifetime issues I was dealing with as well as ugly pointer casting. Signed-off-by: Jadon Fowler <j@jadon.io>
Signed-off-by: Jadon Fowler <j@jadon.io>
Signed-off-by: Jadon Fowler <j@jadon.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all shared state between structs in the IR by removing Arcs and Mutexes and replacing them with constant IDs for declarations, blocks, & instructions. This method is much nicer to use in Rust since Rust demands many things when using pointers.
The tests are working but there are still a few spots using
unsafeto copy mutable references which can be improved. I was just writing crap code until it compiled.Closes #1 because I have decided using Zig wouldn't be the best decision. The language is too new and even starting out with a basic AST showed issues in the compiler. It's a lovely language but it's not ready yet.