-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] OPT-175B service authentication and new priority queue #852
Conversation
Example informal test that I've done: I set the weight for API key I've run the following on the command line
At the same time, I start making requests with several tabs on the web interface. The result is that:
|
9f4ba19
to
2fd6772
Compare
Thanks for your contribution. I replied to your comments. I will review this PR later this week. |
1fb4654
to
6c33a6d
Compare
…a-projects#700) This commit also adds some checks to improve the robustness of the server process against adversarial inputs, since there are plans to open the API to non-key users.
6c33a6d
to
00425db
Compare
Looks like the code is well-documented and well-tested. The design is what we want in #700 and it carefully considers a lot of potential issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good to hear, I haven't used automated test suites unlike the rest of Alpa but hopefully the informal tests are good enough coverage. I realize that one of the comments is wrong, but that can be fixed elsewhere (I'll include it in #870 in case that feature gets added)
api_key_weights = keys["api_key_weights"] | ||
|
||
# Scheduling | ||
# Each authentication choice - endpoint pair contains a separate queue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an error in the comment, there's a separate queue for each authentication choice, not for the pair of authentication choice and endpoint
See the issue page #700. I made some design choices based on my comment there, see if the design choices make sense.