Add more property tests #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypaq
force-pushed
the
ypaq-more-prop-tests
branch
4 times, most recently
from
1efebcd
to
3a2ac51
Compare
ypaq
commented
Jan 2, 2017
| to_binary({construct, Constructor, Of}) -> | ||
| [to_binary(Constructor), to_binary(Of)]; | ||
| to_binary({union, OfTypes}) -> | ||
| lists:join($|, [to_binary(Type) || Type <- OfTypes]); |
There was a problem hiding this comment.
lists:join is not available in erlang 18.
ypaq
force-pushed
the
ypaq-more-prop-tests
branch
3 times, most recently
from
bbdfe6c
to
73cdb4e
Compare
ypaq
force-pushed
the
ypaq-more-prop-tests
branch
from
73cdb4e
to
49c3f55
Compare
ypaq
force-pushed
the
ypaq-more-prop-tests
branch
2 times, most recently
from
75d5bde
to
36e0cad
Compare
ypaq
commented
Jan 2, 2017
| to_binary({list, Of}) -> | ||
| [<<"list">>, to_binary(Of)]; | ||
| to_binary({map, KeyType, ValueType}) -> | ||
| [<<"map">>, $(, to_binary(KeyType), $), to_binary(ValueType)]; |
There was a problem hiding this comment.
Currently forcing brackets around the key type of a map.
|
There are a couple of references to R18 in |
ypaq
force-pushed
the
ypaq-more-prop-tests
branch
from
36e0cad
to
809736e
Compare
|
Done |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property tests now generate two type declarations, the second one may use the name of the first.
You can now adjust the number of tests with
NUMTESTS=10000 rebar3 ct. The default is 1000 test cases.