Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relax websockets version requirements #435

Merged
merged 2 commits into from Apr 4, 2024

Conversation

hiohiohio
Copy link
Contributor

  • relax websockets version requirements

@hiohiohio hiohiohio marked this pull request as ready for review April 4, 2024 11:56
@hiohiohio hiohiohio merged commit a185920 into master Apr 4, 2024
12 checks passed
@hiohiohio hiohiohio deleted the relax-websocket-dependency branch April 4, 2024 11:58
@impredicative
Copy link

impredicative commented Apr 6, 2024

@hiohiohio What is the reason for relaxing it? Already v12.0 of websockets has been out. Who needs v10 and why? Or is it being relaxed just for generosity reasons?

@impredicative
Copy link

@hiohiohio More importantly, please note that this change now opens up websockets to be automatically updated to v12.0. Has this version been tested?

@hiohiohio
Copy link
Contributor Author

hiohiohio commented Apr 7, 2024

Hey @impredicative , thank you for heads-up! Good point. I have just checked trade events and market data stream (crypto) with websockets v12.0 and seems it works in my env. Based on the changelog of websockets, the incompatibility change is cutting Python 3.7 supports. Their policy is to keep compatibility as much as possible. If you found an issue, please let us know.

The reason of this change is that there was an issue to bump alpaca-py to v0.20.2 due to this websockets requirements in a partner. Without upgrading alpaca-py, alpaca-py could not fetch a trade account via broker api. Therefore, it is a critical issue and required to be resolved quickly. Decided to relax this websockets version requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants