Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new colab notebooks inside examples folder #440

Merged

Conversation

ggrace01
Copy link
Contributor

@ggrace01 ggrace01 commented Apr 9, 2024

Added new notebooks for:

  • stocks
  • crypto

Edited formatting syntax for:

  • options

@ggrace01 ggrace01 requested a review from hiohiohio as a code owner April 9, 2024 20:43
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Left small comments.

examples/crypto-trading-basic.ipynb Outdated Show resolved Hide resolved
" status = QueryOrderStatus.OPEN,\n",
" symbols = [symbol]\n",
")\n",
"open_orders = trade_client.get_orders(req)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider separating cell to show this open_orders.

examples/stocks-trading-basic.ipynb Outdated Show resolved Hide resolved
" status = QueryOrderStatus.OPEN,\n",
" symbols = [symbol]\n",
")\n",
"open_orders = trade_client.get_orders(req)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider separating cell for this open_orders to show.

Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiohiohio hiohiohio merged commit 97a390e into alpacahq:master Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants