-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new colab notebooks inside examples folder #440
Add new colab notebooks inside examples folder #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Left small comments.
" status = QueryOrderStatus.OPEN,\n", | ||
" symbols = [symbol]\n", | ||
")\n", | ||
"open_orders = trade_client.get_orders(req)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider separating cell to show this open_orders.
" status = QueryOrderStatus.OPEN,\n", | ||
" symbols = [symbol]\n", | ||
")\n", | ||
"open_orders = trade_client.get_orders(req)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider separating cell for this open_orders to show.
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added new notebooks for:
Edited formatting syntax for: