Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add validation to ReplaceOrderRequest #445

Merged
merged 4 commits into from Apr 26, 2024
Merged

fix: Add validation to ReplaceOrderRequest #445

merged 4 commits into from Apr 26, 2024

Conversation

hiohiohio
Copy link
Contributor

Context:

  • ReplaceOrderRequest ignores qty/limit_price/stop_price/trail if value is zero
  • this may cause confusion
  • this PR will add validation to ReplaceOrderRequest to let users know that those values should be greater than zero

Change:

  • add validation to ReplaceOrderRequest
  • apply poetry run isort --profile black <file>

gnvk
gnvk approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@gnvk gnvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiohiohio hiohiohio merged commit dda0523 into master Apr 26, 2024
12 checks passed
@hiohiohio hiohiohio deleted the add-validation-to-replace-order-request branch April 26, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnvk gnvk gnvk approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

@matebudai matebudai Awaiting requested review from matebudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiohiohio @gnvk