Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make thread safer #31

Open
umitanuki opened this issue Sep 26, 2018 · 0 comments
Open

Make thread safer #31

umitanuki opened this issue Sep 26, 2018 · 0 comments

Comments

@umitanuki
Copy link
Contributor

Session object from requests is not meant to be thread safe, but the SDK client code can use REST objects in multithread. It happens to be ok for now since it is not mutating anything yet, but things will happen. We should use ThreadLocal to separate session objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@umitanuki