Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark v1 marketdata endpoints deprecated #558

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Mark v1 marketdata endpoints deprecated #558

merged 2 commits into from
Jan 20, 2022

Conversation

gnvk
Copy link
Contributor

@gnvk gnvk commented Jan 19, 2022 •
edited

One additional note: the "overnight hold" example is still using get_barset, however updating it is not completely trivial.

@gnvk gnvk requested a review from camelpac January 19, 2022 09:59
camelpac
camelpac approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@camelpac camelpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. regarding the overnight_hold example. when changes were made there was no support for the rest_async module so using get_bars was problematic. now the solution should be moving to the async rest module and stop using get_barset

@gnvk gnvk merged commit 7970679 into master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelpac camelpac camelpac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnvk @camelpac