Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alpacabkfeeder): extended_hours config #613

Merged
merged 2 commits into from Aug 7, 2022

Conversation

dakimura
Copy link
Contributor

@dakimura dakimura commented Aug 7, 2022

WHAT

  • add extended_hours config in the AlpacaBrokerAPIFeeder plugin.
    • when extended_hours: false, TICK data during the off-hours (= time < openTime and time > closeTime) are dropped and not stored in DB, even when off_hours_schedule is set.
  • see contrib/alpacabkfeeder/README.md for the details.

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #613 (fcf8de3) into master (d517934) will decrease coverage by 0.07%.
The diff coverage is 78.12%.

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   48.31%   48.23%   -0.08%     
==========================================
  Files         136      136              
  Lines       12966    12979      +13     
==========================================
- Hits         6265     6261       -4     
- Misses       6091     6107      +16     
- Partials      610      611       +1     
Impacted Files Coverage Δ
contrib/alpacabkfeeder/configs/config.go 53.42% <54.54%> (-2.64%) ⬇️
contrib/alpacabkfeeder/feed/time_checker.go 57.14% <81.81%> (-29.82%) ⬇️
contrib/alpacabkfeeder/writer/snapshot_writer.go 98.55% <100.00%> (+0.24%) ⬆️

@dakimura dakimura merged commit 5d4fe6c into master Aug 7, 2022
@dakimura dakimura deleted the alpacabkfeeder/extended-hours branch August 7, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants