Test for ViewSubView copy operation #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| case 4: | ||
| { | ||
| std::vector<Elem> v2{75, 76, 78, 79, 91, 92, 95, 96, 139, 140, 143, 144, 155, 156, 159, 160}; |
There was a problem hiding this comment.
For now it would be good if you could comment out the 4 dimensional case here and use if(Dim::value != 4u) in the other test case. This would allow us to merge this independently of a 4D copy support.
|
Update |
| //! Prints all elements of the buffer. | ||
| //----------------------------------------------------------------------------- | ||
| struct PrintBufferKernel { | ||
| template <typename TAcc, |
There was a problem hiding this comment.
Could you please begin with the first type indented on a new line? Furthermore, alpaka does not currently use a space before the <.
|
Thanks for providing such extensive tests! |
|
The logs of the CI are getting to long. Could we reduce the ALPAKA_DEBUG level ? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add two test cases for the ViewSubView class. The first test verifies the copy operation based on a static buffer. The second test verifies the copy operation based on varying buffer sizes and dimensions.
This PR still includes fixes of #158 and #157. The test case can not run through because of #159.
fix CUDA full n-dimensional support #159