Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accelerator clock method #171

Merged
merged 1 commit into from
Feb 19, 2016
Merged

Conversation

BenjaminW3
Copy link
Member

This adds the missing clock64() instruction returning a wall clock time in ticks which was noted in issue #18 as alpaka::time::clock(acc).

@@ -37,7 +37,7 @@
//#############################################################################
//!
//#############################################################################
class BlockSharedMemDyn
class BlockSharedMemDynTestKernel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the renaming in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I wrote a new test kernel, looked for the current naming convention and found that this was the only test kernel that was named inconsistently 😄

@erikzenker
Copy link
Member

Nice Work 👍 but you did also a lot of replacement of comments. Could you separate renamings and replacements which are unrelated to the time feature into a new pull request ?

@BenjaminW3
Copy link
Member Author

Renamings, comment corrections and the time feature are in 3 independent commits, so merging it at once would not introduce any revert problems. However, if you insist on it, I could seperate them when I have time again.

@erikzenker
Copy link
Member

It would be nice to split this PR up into a "new feature" and a "comment" PR. Because, if we search for some changes of code in the future it is easier to understand what happened in this PR.

@BenjaminW3
Copy link
Member Author

The two other commits have been proposed independently as #177 and #178.

@erikzenker
Copy link
Member

Thank you for separating this PR

erikzenker added a commit that referenced this pull request Feb 19, 2016
@erikzenker erikzenker merged commit db94c1f into alpaka-group:develop Feb 19, 2016
@BenjaminW3 BenjaminW3 deleted the topic-time branch February 19, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants