-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add accelerator clock method #171
Conversation
d03aeff
to
b6d1237
Compare
@@ -37,7 +37,7 @@ | |||
//############################################################################# | |||
//! | |||
//############################################################################# | |||
class BlockSharedMemDyn | |||
class BlockSharedMemDynTestKernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the renaming in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I wrote a new test kernel, looked for the current naming convention and found that this was the only test kernel that was named inconsistently 😄
Nice Work 👍 but you did also a lot of replacement of comments. Could you separate renamings and replacements which are unrelated to the time feature into a new pull request ? |
Renamings, comment corrections and the time feature are in 3 independent commits, so merging it at once would not introduce any revert problems. However, if you insist on it, I could seperate them when I have time again. |
It would be nice to split this PR up into a "new feature" and a "comment" PR. Because, if we search for some changes of code in the future it is easier to understand what happened in this PR. |
b6d1237
to
d07c4d0
Compare
7066aa0
to
0824eb4
Compare
0824eb4
to
6dee382
Compare
Thank you for separating this PR |
add accelerator clock method
This adds the missing
clock64()
instruction returning a wall clock time in ticks which was noted in issue #18 asalpaka::time::clock(acc)
.