workDivMembers construction with a user defined type

[mehmetyusufoglu]

WorkDivMembers class constructor could accept any vector type if the necessary traits and functions related to that type are provided.

This PR uses a user-defined vector, related traits and specializations to test the of WorkDivMembers constructors.

• Tests are added to test the usage of the user-defined vectors in WorkDivMembers construction.
• Already existing WorkDivMembers construction tests are improved and refactored.
• Initializer list test is added in construction of WorkDivMembers. auto const workDiv2DUsingInitList = alpaka::WorkDivMembers<Dim2D, Idx>({6, 9}, {4, 6}, {1, 1}); initializes 3 alpaka vectors as arguments.

[fwyzard]

Rather than std::arrays (or in addition to them, if there is any concrete use case), could you add support for [std::initializer_list](https://en.cppreference.com/w/cpp/utility/initializer_list) arguments ?

That would support alpaka::WorkDivMembers{{1u, 1u}, {2u, 2u}, {1u, 1u}};.

[psychocoderHPC]

There is no need for an additional method that can only handle std array.
We have the traits GetExtents to provide the translation that alpaka can work with alpaka foreign types.

[mehmetyusufoglu]

Ok I used getExtents. There is already one implemented for 1D array arguments in "ViewPlanePtr" therefore I had to check the dimension. I will refine the solution. Thanks a lot.

[bernhardmgruber]

That would support alpaka::WorkDivMembers{{1u, 1u}, {2u, 2u}, {1u, 1u}};.

This may already work with #2240, if the right constructor is selected. I think alpaka::Vec can be created from an initializer list.

[bernhardmgruber]

That would support alpaka::WorkDivMembers{{1u, 1u}, {2u, 2u}, {1u, 1u}};.

This may already work with #2240, if the right constructor is selected. I think alpaka::Vec can be created from an initializer list.

It turns out it doesn't work, and I am not exactly sure why. The compiler fails to deduce the template parameters of the deduction guide. It has something to do with {1u, 1u} being an initializer list, because alpaka::WorkDivMembers{alpaka::Vec{1u, 1u}, {2u, 2u}, {1u, 1u}}; works successfully.

[mehmetyusufoglu]

Yes, i also tried. Did not work. 26 Şub 2024 Pzt 21:23 tarihinde Bernhard Manfred Gruber < ***@***.***> şunu yazdı:

…

That would support alpaka::WorkDivMembers{{1u, 1u}, {2u, 2u}, {1u, 1u}};. This may already work with #2240 <#2240>, if the right constructor is selected. I think alpaka::Vec can be created from an initializer list. It turns out it doesn't work, and I am not exactly sure why. The compiler fails to deduce the template parameters of the deduction guide. It has something to do with {1u, 1u} being an initializer list, because alpaka::WorkDivMembers{alpaka::Vec{1u, 1u}, {2u, 2u}, {1u, 1u}}; works successfully. — Reply to this email directly, view it on GitHub <#2243 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUYXIJODKPJDMBYKBIDZ5YTYVTVNPAVCNFSM6AAAAABDZLEFFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGE4DSMZZHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mehmetyusufoglu]

Rather than std::arrays (or in addition to them, if there is any concrete use case), could you add support for [std::initializer_list](https://en.cppreference.com/w/cpp/utility/initializer_list) arguments ?

That would support alpaka::WorkDivMembers{{1u, 1u}, {2u, 2u}, {1u, 1u}};.

Currently the following are possible due to a merged PR: alpaka::WorkDivMembers<Dim2D,Idx>{{1u, 1u}, {2u, 2u}, {1u, 1u}}; . OR alpaka::WorkDivMembers{Vec{1u, 1u}, Vec{2u, 2u}, Vec{1u, 1u}}; Vec is alpaka::vec with specific Dim and Idx.

I will consider your suggestion together with C++20, seems more reasonable I think.

[bernhardmgruber]

Here are a few comments:

[bernhardmgruber]

Suggested change

	template<typename T, typename = void>
	struct has_member_arr : std::false_type
	{
	};
	template<typename T>
	struct has_member_arr<T, std::void_t<decltype(&T::arr)>> : std::true_type
	{
	};
	//! The DimType specialization for the user defined vector which has a member called "arr"
	//! \tparam T The vector type
	template<typename T>
	struct DimType<T, std::enable_if_t<has_member_arr<T>::value>>
	//! The DimType specialization for the user defined vector which has a member called "arr"
	//! \tparam T The vector type
	template<typename T>
	struct DimType<FooVec>

Why don't you just specialize for FooVec directly? I don't see a need for SFINAE here.

Applies to other traits as well.

[mehmetyusufoglu]

FooVec is a template, not a type. But i will try to formulate your approach.

[bernhardmgruber]

Sorry, my bad. Should be:

template<typename TVec, std::size_t Size>
struct DimType<FooVec<TVec, Size>>

[mehmetyusufoglu]

done thanks.

[mehmetyusufoglu]

Yes, i've already did like this actually. Testing,. Bernhard Manfred Gruber ***@***.***>, 8 Mar 2024 Cum, 13:37 tarihinde şunu yazdı:

…

***@***.**** commented on this pull request. ------------------------------ In test/unit/workDiv/src/FooVec.hpp <#2243 (comment)>: > + template<typename T, typename = void> + struct has_member_arr : std::false_type + { + }; + + template<typename T> + struct has_member_arr<T, std::void_t<decltype(&T::arr)>> : std::true_type + { + }; + + //! The DimType specialization for the user defined vector which has a member called "arr" + //! \tparam T The vector type + template<typename T> + struct DimType<T, std::enable_if_t<has_member_arr<T>::value>> Sorry, my bad. Should be: template<typename TVec, std::size_t Size>struct DimType<FooVec<TVec, Size>> — Reply to this email directly, view it on GitHub <#2243 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUYXIJIFC3B5I64OYQ333OLYXGWKHAVCNFSM6AAAAABDZLEFFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRUG44TKNZYGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>