math/abs: Added trait specialisation for double. #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Int is also supported in cuda/hip, so fmod is used for double type.
BenjaminW3
previously approved these changes
Oct 18, 2019
ax3l
previously approved these changes
Oct 22, 2019
ax3l
reviewed
Oct 22, 2019
Included commit suggestion from Axel Huebl Co-Authored-By: Axel Huebl <axel.huebl@plasma.ninja>
|
@jkrude I stopped the CI because the first tests failed so that we can test also other pull requests: errors: |
sbastrakov
reviewed
Oct 23, 2019
sbastrakov
suggested changes
Oct 23, 2019
sbastrakov
approved these changes
Oct 23, 2019
psychocoderHPC
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In include/alpaka/math/abs:
Int is also supported in cuda/hip, so fabs is used for double type.
abs for int
fabs for double <-- was missing
fabsf for float