Add support for Visual Studio 2019 #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of Github Actions for building on Windows with Visual Studio 2019. We already use this for updating the doxygen documentation and it looks like the next reasonable step. Especially because it allows for 20 parallel builds for open source projects whereas Travis only had 5.
|
ready for review/merge ;-) |
|
Is this a replacement for travis tests? or an addition for the windows tests? Only a note: we are working on getting the HZDR CI into alpaka to support scalable tests on multiple architectures (Linux, maybe MACOSX). Windows will stay on travis. |
psychocoderHPC
approved these changes
Mar 10, 2020
|
Currently this is both. VS 2019 tests are new but now directly within github. My goal is to move all the tests from travis to github. This would remove the necessity for yet another account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of Github Actions for building on Windows with Visual Studio 2019.
We already use GitHub Actions for updating the doxygen documentation and it looks like the next reasonable step. Especially because it allows for 20 parallel builds for open source projects whereas Travis only has 5.