test_process_annex_info_batch: fix test for git-annex 20180719 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since git-annex 20180719 the `git-annex info` command displays UUID and description when a repository is identified by uuid. This broke the test_process_annex_info_batch case which parses the output of `git-annex info` output. See https://git-annex.branchable.com/news/version_6.20180719/
9 tasks
|
Thanks for the fix! I would've preferred to update the reference text with a working version, but the new format has UUID and machine names in them, hard to reproduce across runs/machines. Especially when the format is not what I'm testing for. |
agreed. This was the easiest fix ATM to remain compatible with the latest |
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Aug 16, 2018
`git-annex` version 6.20180719 enhances the output of `git-annex info` with a description and UUID of the repository which broke the testcase `test_process_annex_info_batch` which parses the output of the info command. The testcase has been fixed accordingly and the patch was filed upstream here: alpernebbi/git-annex-adapter#6 I rechecked the functionality in a simple python environment with the following expression: ``` with import ./. {}; python3.withPackages (ps: with ps; [ git-annex-adapter ]) ``` Furthermore I tested the main functionality in a Python REPL within the environment. The Darwin patch fixes tests that rely on `rev`, a binary which is distributed in the `utillinux` package and not available on Nix with Darwin. To make the purpose of the patches for future contributors clear I documented the purpose for each patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since git-annex 20180719 the
git-annex infocommand displays UUID anddescription when a repository is identified by uuid.
This broke the test_process_annex_info_batch case which parses the
output of
git-annex infooutput.See https://git-annex.branchable.com/news/version_6.20180719/