Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace existing legacy CRUD controllers with ActiveRecordController #211

Closed
alphadevx opened this issue Sep 1, 2015 · 0 comments
Closed

Replace existing legacy CRUD controllers with ActiveRecordController #211

alphadevx opened this issue Sep 1, 2015 · 0 comments
Labels
enhancement
Milestone
2.0.0

Comments

@alphadevx
Copy link
Owner

The new ActiveRecordController is designed to replace the following controllers:

  1. CreateController
  2. ViewController
  3. EditController
  4. ListController

Those controllers should be removed, along with all references to them (links, extensions, and unit tests), and replaced with references to ActiveController.

The overall aim is to reduce code complexity and duplication (e.g. there are multiple doDELETE() methods).
@alphadevx alphadevx added this to the 2.0.0 milestone Sep 1, 2015
alphadevx added a commit that referenced this issue Sep 2, 2015
@alphadevx
#211 - removed the CreateController along with links and unit tests, …
9b9ef49 
…and moved the logic to render the admin menu to the Controller parent class to reduce some duplication
alphadevx added a commit that referenced this issue Sep 3, 2015
@alphadevx
#211 - removed the EditController along with links and unit tests
444be9d
alphadevx added a commit that referenced this issue Sep 4, 2015
@alphadevx
#211 - removed the ViewController along with links to it and unit tests
f88ac43
alphadevx added a commit that referenced this issue Sep 5, 2015
@alphadevx
#211 - removed the ListController along with all links to it
b3834a1
alphadevx added a commit that referenced this issue Sep 6, 2015
@alphadevx
#211 - fixed the List All link rendered by the RendererProviderHTML c…
ac40490 
…lass
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - fixed the pagination links in the ActiveRecordController
4bfd7f2
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - further fixes to the pagination links in the ActiveRecordContr…
de4fefc 
…oller, and updated the TagController to support simple record linking
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - updated the TagController to support simple record creation an…
0a8fb27 
…d editing
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - fixed the Back to List button on the edit screen, and updated …
9d62250 
…it to use the new ViewState::selectedStart integer to remember the start position on the list we are returning to
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - fixed example links in the GenSecureQueryStringController, and…
af4b1a5 
… fixed a bug in FeedController affecting the loading of the desired active record class
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - removing the vendor directory from the code metrics inspector
a27444d
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - fixed a bug in calling the CacheController::doGET() with the w…
e926ce8 
…rong parameter
alphadevx added a commit that referenced this issue Sep 7, 2015
@alphadevx
#211 - fixed a bug in the FeedControllerTest class
34ec786
alphadevx added a commit that referenced this issue Sep 8, 2015
@alphadevx
#211 - renamed Controller::getBO() and Controller::setBO() methods to…
3e5fb4b 
… Controller::getRecord() and Controller::setRecord()
alphadevx added a commit that referenced this issue Sep 8, 2015
@alphadevx
#211 - fixed a small bug in the LogoutController affecting a unit test
699da2b
alphadevx added a commit that referenced this issue Sep 11, 2015
@alphadevx
#211 - refactoring out the custom doPOST() method from the ArticleCon…
fce7f2c 
…troller class
alphadevx added a commit that referenced this issue Sep 11, 2015
@alphadevx
#211 - fully removed the redundent ArticleController::doPOST() method
10f64e4
alphadevx added a commit that referenced this issue Sep 13, 2015
@alphadevx
#211 - fixed a re-direct issue affecting the creation of a new Article
33beb44
alphadevx added a commit that referenced this issue Sep 13, 2015
@alphadevx
#211 - removed the majority of the custom logic from the ArticleContr…
10513b3 
…oller::doDELETE() method, with the exception of a call to clear the unit of work from the session which was causing a bad re-direct
alphadevx added a commit that referenced this issue Sep 14, 2015
@alphadevx
#211 - removed the custom logic from ArticleController::doPUT() for s…
7d954c4 
…aving an existing comment
alphadevx added a commit that referenced this issue Sep 14, 2015
@alphadevx
#211 - removed the custom logic from ArticleController::doPUT() for s…
70f8fbc 
…aving an existing Article record
alphadevx added a commit that referenced this issue Sep 14, 2015
@alphadevx
#211 - fixed the article attachment upload/delete functionality and r…
2a1bf69 
…elated unit tests
alphadevx added a commit that referenced this issue Sep 15, 2015
@alphadevx
#211 - fixed the Back to record button link on the edit record tags s…
06f69d2 
…creen
alphadevx added a commit that referenced this issue Sep 15, 2015
@alphadevx
#211 - improved the logic of the redirect used in the ArticleControll…
4072426 
…er::doPUT() method
alphadevx added a commit that referenced this issue Sep 15, 2015
@alphadevx
#211 - the FrontController no longer overwrites existing Request para…
3329c02 
…ms when parsing additional params from the secure token on /tk/ requests
alphadevx added a commit that referenced this issue Sep 15, 2015
@alphadevx
#211 - the Request class no longer overwrites existing Request params…
4567932 
… when parsing additional params from the named params provided on routes added via the FrontController
alphadevx added a commit that referenced this issue Sep 15, 2015
@alphadevx
#211 - reduced the amount of code in the TagController::doDELETE() me…
b71b026 
…thod to reduce duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@alphadevx