Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Alpha on PHP7 and fix any resulting issues #270

Closed
alphadevx opened this issue Mar 15, 2016 · 5 comments
Closed

Test Alpha on PHP7 and fix any resulting issues #270

alphadevx opened this issue Mar 15, 2016 · 5 comments
Assignees
Milestone

Comments

@alphadevx
Copy link
Owner

No description provided.

@alphadevx alphadevx added this to the 2.0.4 milestone Mar 15, 2016
@alphadevx alphadevx self-assigned this Mar 15, 2016
@alphadevx
Copy link
Owner Author

This should include setting up PHP7 build on Travis CI.

@alphadevx
Copy link
Owner Author

It is possible to install PHP7 in parallel to PHP5.6 locally on Fedora, notes are here:

http://blog.remirepo.net/pages/PECL-extensions-RPM-status

And here:

http://blog.remirepo.net/post/2015/03/25/PHP-7.0-as-Software-Collection

@alphadevx
Copy link
Owner Author

So it seems that "String" is a reserved word in PHP 7, resulting in the following fatal error:

PHP message: PHP Fatal error: Cannot use Alpha\Model\Type\String as String because 'String' is a special class name in...

Ref: http://php.net/manual/en/reserved.other-reserved-words.php

@alphadevx
Copy link
Owner Author

Moving this to a new 3.0.0 release as the upgrade to PHP 7 will force backwards-compatibility breaking changes, e.g. renaming our core String class to something else.

@alphadevx alphadevx modified the milestones: 3.0.0, 2.0.4 Nov 14, 2016
@alphadevx
Copy link
Owner Author

PHP unit tests are now failing immediately due to this error:

vendor/bin/phpunit test --stop-on-failure PHP Fatal error: Cannot use Alpha\Model\Type\String as String because 'String' is a special class name in /home/john/Git/alpha/test/Alpha/Test/Model/ActiveRecordTest.php on line 15

The first thing I will try is to rename Alpha\Model\Type\String to Alpha\Model\Type\SmallText to try to fix the tests.

alphadevx added a commit that referenced this issue Jan 2, 2017
alphadevx added a commit that referenced this issue Jan 3, 2017
alphadevx added a commit that referenced this issue Jan 3, 2017
alphadevx added a commit that referenced this issue Jan 3, 2017
…tring class to SmallText, resulting in all unit tests now working again
alphadevx added a commit that referenced this issue Jan 4, 2017
…onfig file to try to get it to install the Memcached extension
alphadevx added a commit that referenced this issue Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant