Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce private methods to decompose 10 most complex methods highlighted by Scrutinizer #322

Closed
alphadevx opened this issue Aug 17, 2017 · 1 comment
Closed

Introduce private methods to decompose 10 most complex methods highlighted by Scrutinizer #322

alphadevx opened this issue Aug 17, 2017 · 1 comment
Assignees
@alphadevx
Labels
refactor
Milestone
3.0.0

Comments

@alphadevx
Copy link
Owner

From this list: https://scrutinizer-ci.com/g/alphadevx/alpha/code-structure/develop/hot-spots

The 10 worse offending methods are currently:

F | Controller\ActiveRecordController::doGET()
F | ArticleController::before_displayPageFoot_callback()
F | ActiveRecordProviderMySQL::checkIndexes()
F | Util\Http\Request::__construct()
F | ActiveRecordProviderMySQL::save()
F | ActiveRecordProviderSQLite::save()
F | ActiveRecordProviderMySQL::loadByAttribute()
F | RendererProviderHTML::adminView()
F | Controller\ArticleController::doPUT()
F | RendererProviderHTML::listView()
@alphadevx alphadevx added this to the 3.0.0 milestone Aug 17, 2017
@alphadevx alphadevx self-assigned this Aug 17, 2017
alphadevx added a commit that referenced this issue Aug 20, 2017
@alphadevx
#322 - adding the private ActiveRecordController::renderRecord() method
2eecbb4
alphadevx added a commit that referenced this issue Aug 24, 2017
@alphadevx
#322 - adding the private ActiveRecordController::renderRecords() method
61fadb0
alphadevx added a commit that referenced this issue Dec 7, 2017
@alphadevx
#322 - added the private Request::getGlobalServerValue() method to st…
dabc0d5 
…art to decompose the Request constructor and reduce the amount of calls to the _SERVER super global
alphadevx added a commit that referenced this issue Dec 7, 2017
@alphadevx
#322 - adding back in a use statement to the Article class to load Co…
66099b5 
…nfigProvider which is required
alphadevx added a commit that referenced this issue Dec 9, 2017
@alphadevx
#322 - adding more calls to Request::getGlobalServerValue()
a617ec5
alphadevx added a commit that referenced this issue Dec 9, 2017
@alphadevx
#322 - added the ArticleController::renderTags() private method
bc6f277
alphadevx added a commit that referenced this issue Dec 9, 2017
@alphadevx
#322 - added the ArticleController::renderVotes() private method
004a61a
alphadevx added a commit that referenced this issue Dec 9, 2017
@alphadevx
#322 - added the ArticleController::renderStandardFooter() private me…
75ca320 
…thod
alphadevx added a commit that referenced this issue May 19, 2018
@alphadevx
#322 - added the bootstrapconfirmokay.phtml template fragment and loa…
9d86cd5 
…ding it from the RendererProviderHTML class to reduce duplicated JS code
alphadevx added a commit that referenced this issue May 19, 2018
@alphadevx
#322 - more updates to RendererProviderHTML to use the new bootstrapc…
55adb83 
…onfirmokay.phtml template fragment duplicated JS code
alphadevx added a commit that referenced this issue May 19, 2018
@alphadevx
#322 - updated the CacheController and ArticleView classes to use the…
cd5d3f0 
… new bootstrapconfirmokay.phtml template fragment to reduce duplicated JS code
alphadevx added a commit that referenced this issue May 19, 2018
@alphadevx
#322 - updating copyright to 2018 and version to 3.0.0-RC.1
b19eac8
alphadevx added a commit that referenced this issue May 19, 2018
@alphadevx
#322 - updated the release note for 3.0.0-RC.1
3ca6a1f
@alphadevx
Copy link
Owner Author

Closing for now as I have already committed 13 improvements against this, and it is holding up the 3.0 GA release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphadevx alphadevx

Labels
refactor
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@alphadevx