Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with selecting items from dropdown #408

Closed
martinlex opened this issue Jan 20, 2020 · 7 comments · Fixed by #410
Closed

Issue with selecting items from dropdown #408

martinlex opened this issue Jan 20, 2020 · 7 comments · Fixed by #410
Milestone

Comments

@martinlex
Copy link

We have a kind of special situation:
My colleague can fail to select an item from the list, whereas I cannot.
When she clicks, it behaves like pressing "ESC", meaning: the item is not selected, it just keeps whatever you wrote, and closes the dropdown.
I, on the other hand, cannot recreate this bug. We have tried with Mac (both clickpad and mouse) and Dell laptop (both clickpad and mouse).
It seems to me, when I click very gently and very softly, I can recreate it (sometimes).
It sounds so silly, I know 😂😂
Is there a known problem with "light/short clicking" and "hard/long clicking"???
Don't know where to go from here, please help.

@NickColley
Copy link
Contributor

I think this might be related to : #328

@martinlex
Copy link
Author

Oh, thanks! So we were not alone! It looks like the pull request for this fix has merge conflicts. Will this fix be approved and merged later on?

@NickColley
Copy link
Contributor

@martinlex I've asked the team about this, we didnt plan on fixing this bug as we don't have much time right now.

That pull request may or may not fix this issue so we'd need to do more work.

If I don't get back to you sooner I've put 'awaiting-triage' on this card which we use to keep track of cards we need to talk about as a team.

Thanks for your patience.

@NickColley NickColley added the awaiting triage Needs triaging by team label Jan 20, 2020
@martinlex
Copy link
Author

@NickColley
Thanks Nick. Meanwhile, is there a fix I can apply locally? We are loading from npm module.

@NickColley
Copy link
Contributor

@martinlex I'm not aware of a quick easy fix since I don't understand why this problem is happening, sorry I can't be more helpful sorry Martin!

@martinlex
Copy link
Author

I understand. The PR #342 adds a mouseDown event
onMouseDown={(event) => this.handleOptionClick(event, index)}
Have you tried to see if that is the solution?
Thank you for the feedback 👍

@NickColley
Copy link
Contributor

I'll have a poke around to see what I can learn and let you know if there's anything helpful short term/ long term.

@kellylee-gds kellylee-gds removed the awaiting triage Needs triaging by team label Jan 27, 2020
@36degrees 36degrees added this to the Next milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants