Fix long clicks not selecting options #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
changed the title
NickColley
force-pushed
the
fix-long-click-issue-round-2
branch
from
c75aaea
to
2ae3f55
Compare
NickColley
force-pushed
the
fix-long-click-issue-round-2
branch
from
2ae3f55
to
670f9ca
Compare
36degrees
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Great work getting to the bottom of this 👍
I've done some testing in IE11 (Windows 10), reproduced the original issue in the country and territory autocomplete, and tested the country and territory autocomplete with this branch installed.
Seems to fix the issue without reintroducing the original problem.
NickColley
added a commit
that referenced
this pull request
Jan 30, 2020
### Fixes - [Pull request #388: Set aria-selected as a string instead of a boolean to avoid being dropped.](#388) - [Pull request #400: Remove pointer events check.](#400) - [Pull request #406: Make hint padding match input padding.](#406) - [Pull request #407: Use a div element to wrap enhanced component.](#407) - [Pull request #410: Fix long clicks not selecting options.](#410)
NickColley
added a commit
that referenced
this pull request
Jan 30, 2020
### Fixes - [Pull request #388: Set aria-selected as a string instead of a boolean to avoid being dropped.](#388) - [Pull request #400: Remove pointer events check.](#400) - [Pull request #406: Make hint padding match input padding.](#406) - [Pull request #407: Use a div element to wrap enhanced component.](#407) - [Pull request #410: Fix long clicks not selecting options.](#410)
Merged
peterjaric
pushed a commit
to uppsala-university/accessible-autocomplete
that referenced
this pull request
Apr 28, 2020
### Fixes - [Pull request alphagov#388: Set aria-selected as a string instead of a boolean to avoid being dropped.](alphagov#388) - [Pull request alphagov#400: Remove pointer events check.](alphagov#400) - [Pull request alphagov#406: Make hint padding match input padding.](alphagov#406) - [Pull request alphagov#407: Use a div element to wrap enhanced component.](alphagov#407) - [Pull request alphagov#410: Fix long clicks not selecting options.](alphagov#410)
peterjaric
pushed a commit
to uppsala-university/accessible-autocomplete
that referenced
this pull request
Apr 28, 2020
### Fixes - [Pull request alphagov#388: Set aria-selected as a string instead of a boolean to avoid being dropped.](alphagov#388) - [Pull request alphagov#400: Remove pointer events check.](alphagov#400) - [Pull request alphagov#406: Make hint padding match input padding.](alphagov#406) - [Pull request alphagov#407: Use a div element to wrap enhanced component.](alphagov#407) - [Pull request alphagov#410: Fix long clicks not selecting options.](alphagov#410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through exploring this issue I've determined that a change to fix a bug is the reason why doing a long click will not work on the autocomplete since the click needs to finish in 200ms.
I've explored an alternative but tried reverting this specific commit and then testing custom templates in Internet Explorer 11 and cannot reproduce the original issue.
Fixes #408
Fixes #328
Closes #409 (alternative try at fixing this)
Closes #342 (alternative try at fixing this)