Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow an empty defaultValue option for enhanceSelectElement #128

Merged
merged 1 commit into from May 12, 2017
Merged

Allow an empty defaultValue option for enhanceSelectElement #128

merged 1 commit into from May 12, 2017

Commits on May 12, 2017

  1. Allow an empty defaultValue option for enhanceSelectElement 

    The check for a default value option matches false-y values, but that also catches the case where the default value is explicitly set to an empty string.

Add an extra condition for the case where the default value is '' so that it is not overwritten with the content of the first `<option>`.
    @lennym
    lennym committed May 12, 2017
    Configuration menu
    Copy the full SHA
    a864d57 View commit details
    Browse the repository at this point in the history